On 2017/6/25 22:14, Amir Goldstein Wrote: > If a non-merge dir in an overlay mount has an overlay.origin xattr, it > means it was once an upper merge dir, which may contain whiteouts and > then the lower dir was removed under it. > > Do not iterate real dir directly in this case to avoid exposing whiteouts. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > --- > fs/overlayfs/readdir.c | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) > > Yi, > > You missed a very big spot and so did I in review. > Your patch doen't hide whiteouts from readdir and it doesn't > even pass you own xfstest... > > Anyway, here are the missing parts picked from my impure readdir > patch. > Hi Amir, Yes, I missed whiteouts check in readdir because I saw your readdir patch has already fix it, so my xfstest test this case. Do you think we should merge this two patch ? Thanks, ZhangYi. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
