On 2017/6/16 17:57, Miklos Szeredi wrote: > On Fri, Jun 16, 2017 at 11:50 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >> On Fri, Jun 16, 2017 at 10:55 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>> On Fri, Jun 16, 2017 at 10:39 AM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote: >>>> On 2017/6/16 14:02, Amir Goldstein Wrote: >>>>> On Fri, Jun 16, 2017 at 6:55 AM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote: >>>>>> Hi All: >>>>>> >>>>>> I found another problem about impure upper dir which have left >>>>>> whiteout files. If an "impure && not merged" upper dir have >>>>>> left whiteout files(last mount created), ovl cannot clear this >>>>>> dir when we removing it, which may lead to rmdir fail or temp >>>>>> file left in workdir. >> >> Thanks for the report and patch. >> >> I think the unlink failures are indicative of a bigger problem, >> though: we optimize directory reading (and empty checking) based on >> the MERGE flag. This results in the whiteout being returned in the >> directory listing in your test case. >> >> Fortunately we now have a way to identify directories that may contain >> whiteouts: the "overlay.origin" xattr. So I think we should switch to >> using that instead of the MERGE flag for deciding whether we can use > ^^^^^^^^^ > That should be "in addition to" not "instead of". > I think these have been done by Amir in his patch "ovl: consistent st_ino/d_ino" on June 1. :) Thanks, ZhangYi -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
