On Fri, May 19, 2017 at 4:37 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > Well, even if we go by the route of looking up the overlay dentry, we > shoudn't be hacking around the permission checks (yeah, overlayfs > started out doing that, because I didn't know better at the time). > Instead we can export __lookup_hash() and use that. > > But I simply don't know which route is better. There's a tradeoff > between memory use and performance, but all depends on usage patterns. > Probably doesn't matter much, so just choose the one which you feel > better about. > So I chose exporting a new helper to lookup hash. And now that I also relaxed the samefs constrain from constant st_ino, I realize that for non-samefs directory, st_ino is the overlay i_ino, which means that without looking up the overlay dentry of subdirs, there is no way for st_ino to be consistent with d_ino... Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
