We can't do a "goto out_dput;" because "newdentry" isn't initialized yet. Fixes: 02cac3227a28 ("ovl: mark upper dir with type origin entries "impure"") Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c index 5ad6ccf2159e..9b221cf50cb7 100644 --- a/fs/overlayfs/dir.c +++ b/fs/overlayfs/dir.c @@ -973,13 +973,13 @@ static int ovl_rename(struct inode *olddir, struct dentry *old, if (ovl_type_origin(old) && !ovl_type_merge(new->d_parent)) { err = ovl_set_impure(new->d_parent, new_upperdir); if (err) - goto out_dput; + goto out_revert_creds; } if (!overwrite && ovl_type_origin(new) && !ovl_type_merge(old->d_parent)) { err = ovl_set_impure(old->d_parent, old_upperdir); if (err) - goto out_dput; + goto out_revert_creds; } } -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html