The truncate and ftruncate syscalls check the IS_APPEND() flag
in 2 different vfs code paths and I had to fix both in order to
fix overlayfs IS_APPEND() violations.
Add the ftruncate test to t_immutable, so overlay/030 can verify
the fix.
Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
---
src/t_immutable.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
Eryu,
Added another patch to the series.
It stands by itself regardless of test overlay/030, but
together with overlay/030 they provide full coverage of the
kernel fixes I posted.
Amir.
diff --git a/src/t_immutable.c b/src/t_immutable.c
index 8a12d2c..7a7195e 100644
--- a/src/t_immutable.c
+++ b/src/t_immutable.c
@@ -892,6 +892,21 @@ static int test_append(const char *dir)
}
errno = 0;
+ if ((fd = open(path, O_RDWR|O_APPEND)) == -1) {
+ fprintf(stderr, "open(%s, O_RDWR|O_APPEND) failed: %s\n", path, strerror(errno));
+ fail++;
+ } else {
+ if (ftruncate(fd, 0) != -1) {
+ fprintf(stderr, "ftruncate(%s, 0) did not fail\n", path);
+ fail++;
+ } else if (errno != EPERM) {
+ fprintf(stderr, "ftruncate(%s, 0) did not set errno == EPERM\n", path);
+ fail++;
+ }
+ close(fd);
+ }
+
+ errno = 0;
if (truncate(path, 0) != -1) {
fprintf(stderr, "truncate(%s, 0) did not fail\n", path);
fail++;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
