On Mon, Dec 19, 2016 at 6:22 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Mon, Dec 19, 2016 at 06:15:08PM +0200, Amir Goldstein wrote: >> Verify correct d_type values of dir enrties. >> >> This test would fail for file systems with no d_type support, >> but I have no idea how to test d_type support in a generic way, >> without confusing a bug of d_type = DT_UNKNOWN with no support. > > XFS v4 without the rare ftype feature is such a file system. > > We'll need to detect it, and I think a large enough directory where > all entries but . and .. are DT_UNKNOWN should be a clear indicator. > > If that's a bug it's clearly not distinguishable from a non-buggy fs :) For xfs and ext* I know how to test if the feature is enabled and I probably should do that. The question is what to do with the rest of the fs. I can do the heuristic test you suggested... -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
