On Mon, Nov 21, 2016 at 3:38 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Mon, Nov 21, 2016 at 2:04 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> There is really no good reason why not to make all >> directories opaque from birth. >> >> The benefit of making directiories opaque on creation >> is that lookups can stop short when they reach the >> original created directory. >> >> The best case is overlay with N layers, performing >> lookup for first level directory, which exists only in upper. >> In that case, there will be only one lookup instead of N. > > That's true for directories created in a merged dir. Directories > created in an opaque dir get no such advantage and creating the xattr > will consume space and time. > > So this should at least be conditional on the state of the parent. > Will do. But do you at least agree to unconditionally set dir opaque on rename? There is really very little point is finding out if lower_is_positive() Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
