Re: [RFC][PATH 4/4] ovl: relax lock_rename when moving files between work and upper dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 11, 2016 at 04:43:57PM +0200, Amir Goldstein wrote:

> > Surely, the copying of data itself is outside of that lock, isn't it?
> 
> Mmmmmm, no it isn't, but I am going to make it right.

Well, if you really have the copyup itself done under lock_rename(), you
are looking at potentially copying gigabytes of data from r/o layer to
workdir under fs-wide lock.  _That_ is really asking for contention from
hell, and for no good reason.  Renames/whiteout creations/removals are
trivial noise compared to that.  I'm somewhat surprised, TBH - I thought
the copyup itself is done outside of that thing.  Are you sure it really
isn't?
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux