Re: [PATCH v6 15/16] xattr: Stop calling {get,set,remove}xattr inode operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 29, 2016 at 05:48:44PM +0200, Andreas Gruenbacher wrote:
> In squashfs and sockfs, add ->set xattr handler operations so that the
> VFS can call ->set without a NULL check.
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
> +	if (!handler->set)
>  		return -EOPNOTSUPP;

What's the point adding those ->set() instances?  You *do* check for
NULL ->set (which is cheaper than indirect call anyway, so it is the
right thing to do), so...
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux