Re: [PATCH] ovl: avoid setting uninitialized creds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 19, 2016 at 2:38 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> If the call to ovl_copy_up() fails, we now call revert_creds on
> an uninitialized structure after a recent patch, as found
> by "gcc -Wmayby-uninitialized":
>
> fs/overlayfs/inode.c: In function 'ovl_open_maybe_copy_up':
> fs/overlayfs/inode.c:39:2: error: 'old_cred' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> fs/overlayfs/inode.c:22:21: note: 'old_cred' was declared here
>
> This changes the code back to not call revert_creds unless
> we have already called ovl_override_creds().

Thanks.   Slightly reworked fix folded into original patch and pushed out.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux