Re: [PATCH] ovl: fix link error without POSIX ACL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 14, 2016 at 11:54 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> The latest fix for ACL on overlayfs introduced a link error:
>
> fs/built-in.o: In function `ovl_posix_acl_xattr_set':
> file.c:(.text+0x6b320): undefined reference to `posix_acl_from_xattr'
>
> posix_acl_from_xattr doesn't have a 'static inline' implementation when
> CONFIG_FS_POSIX_ACL is disabled, and I could not come up with an obvious
> way to do it.
>
> This instead avoids the link error by defining two sets of ACL operations
> and letting the compiler drop one of the two at compile time depending
> on CONFIG_FS_POSIX_ACL. This avoids all references to the ACL code,
> also leading to smaller code.

Thanks, pushed.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux