Re: [PATCH 2/2] overlay: test copy up files from lower dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 12, 2016 at 07:31:35AM +1100, Dave Chinner wrote:
> On Mon, Jan 11, 2016 at 07:38:21PM +0800, Eryu Guan wrote:
> > Test copy up files from lower dir that are <, =, > 4G in size.
> > 
> > Kernel commit 0480334fa604 ("ovl: use O_LARGEFILE in ovl_copy_up()")
> > fixed bug when copying up large file(>4G) from lower dir.
> > 
> > Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
> > ---
> >  tests/overlay/001      | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/overlay/001.out  |  2 ++
> >  tests/overlay/Makefile | 20 +++++++++++++
> >  tests/overlay/group    |  6 ++++
> >  4 files changed, 104 insertions(+)
> >  create mode 100755 tests/overlay/001
> >  create mode 100644 tests/overlay/001.out
> >  create mode 100644 tests/overlay/Makefile
> >  create mode 100644 tests/overlay/group
> > 
> > diff --git a/tests/overlay/001 b/tests/overlay/001
> > new file mode 100755
> > index 0000000..5025a69
> > --- /dev/null
> > +++ b/tests/overlay/001
> > @@ -0,0 +1,76 @@
> > +#! /bin/bash
> > +# FS QA Test 002
> 
> 002 != 001 ;)

Ah, I missed that after "mv 002 001"..

> 
> > +_scratch_mkfs
> > +
> > +# Create test files with different sizes in lower dir
> > +# $SCRATCH_DEV is actually a test dir used in overlay testing
> > +mkdir -p $SCRATCH_DEV/lower
> 
> This needs to matchup with the overlay configuration. Perhaps there
> needs to be exported variables for this....

Makes sense. I thought about it too but didn't go any further, but will
now. Thanks for the review!

Eryu
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux