On Wed, Dec 09, 2015 at 12:42:50PM +0800, Linzhe Lee wrote:
> Hi,all
>
> I got problem in using overlayfs over fs not support
> dirent::ftype[such as xfs(-n ftype=0)]. After some dig I realized in
> such situation, function ovl_fill_merge parameter d_type will always
> be DT_UNKNOWN.
>
> I think a warning is needed of course. But because dirent::d_type is
> not widely supported for now. I thought If we can find a way to
> fallback to stat() call in such a situation. How do you think this
> idea?
>
> And, can you suggest a method to do it? I tried these method for now,
> but none work.
>
> 1) Direct get struct inode* from inode::i_ino, Stuck at not found
> a proper abstract function to do it.
> 2) Get to known fs do not support dirent::d_type and workaround.
> Stuck at not found how to know if fs do not support dirent::d_type
> 3) In function ctx.actor [ovl_fill_merge], use function
> lookup_one_len to get file dirent. Stuck at lock.
>
> Any thought is helpful. Thank you !
How about the patch below?
Does that fix the issue?
Thanks,
Miklos
---
fs/overlayfs/readdir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/overlayfs/readdir.c
+++ b/fs/overlayfs/readdir.c
@@ -98,7 +98,7 @@ static struct ovl_cache_entry *ovl_cache
p->ino = ino;
p->is_whiteout = false;
- if (d_type == DT_CHR) {
+ if (d_type == DT_CHR || d_type == DT_UNKNOWN) {
p->next_maybe_whiteout = rdd->first_maybe_whiteout;
rdd->first_maybe_whiteout = p;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
