On Fri, Jun 19, 2015 at 10:29 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > Directory, probably? > >> - dentry = lookup_one_len(name, parent->dentry, namelen); >> + dentry = lookup_one_len(name, parent, namelen); > > ... it would better be one. My point is: without a bloody accessor, there's no way to warn if the use is illegal (i.e. nondirectory). Maybe we won't need file->f_dentry, but we do need a way to WARN about abuse (which there IS probably a significant number already and nothing preventing more). Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html