On 07/31/2013 04:13 AM, Steven Rostedt wrote:
On Wed, 2013-07-31 at 03:56 +0300, Xenia Ragiadakou wrote:#define PORT_WAKE_BITS (PORT_WKOC_E | PORT_WKDISC_E | PORT_WKCONN_E) #define PORT_RWC_BITS (PORT_CSC | PORT_PEC | PORT_WRC | PORT_OCC | \ @@ -528,8 +529,10 @@ void xhci_del_comp_mod_timer(struct xhci_hcd *xhci, u32 status, u16 wIndex) xhci->port_status_u0 |= 1 << wIndex; if (xhci->port_status_u0 == all_ports_seen_u0) { del_timer_sync(&xhci->comp_mode_recovery_timer); - xhci_dbg(xhci, "All USB3 ports have entered U0 already!\n"); - xhci_dbg(xhci, "Compliance Mode Recovery Timer Deleted.\n"); + xhci_dbg_trace(xhci, trace_xhci_dbg_quirks, + "All USB3 ports have entered U0 already!\n"); + xhci_dbg_trace(xhci, trace_xhci_dbg_quirks, + "Compliance Mode Recovery Timer Deleted.\n");Hi Xenia, I see that debug prints are being converted to tracepoints. I'm curious to why you are keeping the newline? Tracepoints will always end with a newline and adding one in the tracepoint will cause the trace to be double spaced. -- Steve} } }
Actually, you are totally right. I will remove it and i will add a '\n' in xhci_dbg(xhci, "%pV", &vaf); That is called internally in xhci_dbg_trace(). Thanks a lot for your quick response. best regards, ksenia -- To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|