On Tue, 25 Jan 2011, Zhang Rui wrote: > On Tue, 2011-01-25 at 00:07 +0800, Henrique de Moraes Holschuh wrote: > > > > > Also, the thermal_aux0 and _aux1, we can use the final format specified by you. > > > > > enum events { > > > > > THERMAL_CRITICAL, > > > > > /* user defined thermal events */ > > > > > THERMAL_USER_AUX0, > > > > > THERMAL_USER_AUX1, > > > > > THERMAL_DEV_FAULT, > > > > > }; > > > > Please give us at least two levels of thermal alarm: critical and emergency > > (or warning and critical -- it doesn't matter much, as long as there are at > > least two levels, and which one comes first is defined by the > > specification). I'd have immediate use for them on thinkpads. > > > > It is probably best to have three levels (warning, critical, emergency). > > Best not to tie the API/ABI to the notion of "too hot", one can also alarm > > when it starts to get to cold. > > > when it's the "too hot" case, what kind of action should be taken upon > the warning/critical/emergency events? > I mean what's the difference between these three levels. *ASSUMING* it is monitoring the box (which is a damn big assumption, and should be stated outright): Warning: do something to stop generating so much heat, warn user, try to increase cooling. Let userspace bother with this. Critical: *STOP* generating so much heat (throttle cpu, throttle GPU, shutdown non-critical devices, etc). Increase cooling to max. WARN the user that a machine emergency exists and shutdown is imminent, and that he has to power off or sleep to ram *NOW*. Emergency: emergency sync, and initiate immediate suspend to ram. If that fails, initiate emergency powerdown. Likely one wants kernel notifiers for this stuff, too, so that we can have in-kernel handlers (optional or not, configurable or not, that is orthogonal to the issue) that can try to do something to help. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html