On Monday 25 October 2010 12:04:28 Ingo Molnar wrote: > > * Thomas Renninger <trenn@xxxxxxx> wrote: > > > New power trace events: > > power:processor_idle > > power:processor_frequency > > power:machine_suspend > > > > > > C-state/idle accounting events: > > power:power_start > > power:power_end > > are replaced with: > > power:processor_idle > > Well, most power saving hw models (and the code implementing them) have this kind of > model: > > enter power saving mode X > exit power saving mode > > Where X is some sort of 'power saving deepness' attribute, right? Sure. But ACPI and afaik this model got picked up for PCI and other (sub-)archs as well, defines state 0 as the non-power saving mode. Same as done here with machine suspend state (S0 is back from suspend) and this model should get picked up when device sleep states get tracked at some time. It's consistent and applies to some well known specifications. Also tracking processor_idle_{start,end} as a separate event makes no sense and there is no need to introduce: processor_idle_start/processor_idle_end machine_suspend_start/machine_suspend_end device_power_mode_start/device_power_mode_end events. Using state 0 as "exit/end", is much nicer for kernel/ userspace implementations/code and the user. Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html