Hi Thomas, The patch looks good to me. A few remarks though: On Fri, Oct 1, 2010 at 5:04 PM, Thomas Renninger <trenn@xxxxxxx> wrote: > New power trace events: > power:processor_idle > power:processor_frequency > power:machine_suspend > > > C-state/idle accounting events: > power:power_start > power:power_end > are replaced with: > power:processor_idle > > and > power:power_frequency > is replaced with: > power:processor_frequency > > power:machine_suspend > is newly introduced, a first implementation > comes from the ARM side, but it's easy to add these events > in X86 as well if needed. The suspend trace points are not present in the patch. As Rafael suggested the best place for the trace point is at kernel/power/suspend.c:suspend_enter(), so it fits all platforms. Also it is good to note that the cpu_id field has been removed from the suspend trace point prototype. > the type= field got removed from both, it was never > used and the type is differed by the event type itself. As proposed recently I think an extra parameter is needed, to return a sub-state, a return code, the real HW state... Is it possible to add it? > perf timechart > userspace tool gets adjusted in a separate patch. I am preparing a patch to pytimechart and will submit it as soon as the kernel code gets merged in. Thanks! Jean -- To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|