On Tue, 25 May 2010 14:39:59 +0200 Thomas Renninger <trenn@xxxxxxx> wrote: > and fix the broken case if a core's frequency depends on others. > > trace_power_frequency was only implemented in a rather ungeneric way > in acpi-cpufreq driver's target() function only. > -> Move the call to trace_power_frequency to > cpufreq.c:cpufreq_notify_transition() where CPUFREQ_POSTCHANGE > notifier is triggered. > This will support power frequency tracing by all cpufreq drivers > > trace_power_frequency did not trace frequency changes correctly when > the userspace governor was used or when CPU cores' frequency depend > on each other. > -> Moving this into the CPUFREQ_POSTCHANGE notifier and pass the cpu > which gets switched automatically fixes this. while I'm no great fan of having a second field in the perf structure for the cpu... I can see that Thomas has a use case where this solves his issue... Acked-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|