On Thu, 31 Oct 2024 09:48:32 +0000 Metin Kaya <metin.kaya@xxxxxxx> wrote: > > As for libtraceevent, it doesn't need a separate prefix for local > > variables compared to exported ones, but that prefix is "tep_" and not > > "traceevent_". > > I believe I did not rename any variables in the libtraceevent patch [1]. > However, I made the following changes in the libtracefs patch [2]: > > -extern const struct tep_format_field common_stacktrace; > +extern const struct tep_format_field tracefs_common_stacktrace; > > -extern pthread_mutex_t toplevel_lock; > +extern pthread_mutex_t tracefs_toplevel_lock; > > Do you recommend keeping them as is or using "tfs_" prefix? Might as well make the change. At least that tells us it's exposed across files in the library. -- Steve
|