Re: [PATCH v1] libtraceevent: Fix event-parse memory leak in process_cond

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 16, 2024 at 5:40 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Tue, 30 Apr 2024 01:03:15 -0700
> Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> > > print fmt: "%s%s%s%s%s", __print_symbolic(REC->exception, { 0, "#" "DE" }, { 1, "#" "DB" }, { 3, "#" "BP" }, { 4, "#" "OF" }, { 5, "#" "BR" }, { 6, "#" "UD" }, { 7, "#" "NM" }, { 8, "#" "DF" }, { 10, "#" "TS" }, { 11, "#" "NP" }, { 12, "#" "SS" }, { 13, "#" "GP" }, { 14, "#" "PF" }, { 16, "#" "MF" }, { 17, "#" "AC" }, { 18, "#" "MC" }), !REC->has_error ? "" : " (", !REC->has_error ? "" : __print_symbolic(REC->error_code, { }), !REC->has_error ? "" : ")", REC->reinjected ? " [reinjected]" : ""
> > > ```
> >
> > Some more context. The place in the input where the leak appears is of
> > a string "?" read as a token at:
> > ? "" : __print_symbolic(REC->error_code, { }), !REC->has_error ? "" :
> > ")", REC->reinjected ? " [reinjected]" : ""
>
> That probably is the cause. That should get handled.

Thanks for landing this, glad I got the logic right.

Ian

> -- Steve





[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux