On 5/17/24 12:00 PM, Steven Rostedt wrote: > On Fri, 17 May 2024 11:50:29 -0700 > Jianfeng Wang <jianfeng.w.wang@xxxxxxxxxx> wrote: > >>> Honestly, I don't think this should be an option. Or if it is, it >>> should be default on. If the retval exists in the trace, it should just >>> be printed. Why ask the user to show it when they spent the time to >>> enable it in the recording? >>> > >> >> I make it a default-off option because the feature changes the output format of >> the 'trace-cmd report'. So to be on the safe side, keep the original format by >> default. Also, the kernel has options (i.e., options/funcgraph-retval and >> options/funcgraph-retval-hex) to enable printing functions' retval in trace.log >> >> >From my point of view, I'd like to see the retval on by default. If you are >> okay, I'd like to make it default on and add an option to display retval in hex. > > Yeah, we can keep both as an option, but make the retval default on. > > It will not change default behavior, as it should only be shown if retval > was recorded in the first place. If it wasn't recorded, the behavior should > be the same regardless of if the retval option is enabled or not in the > trace-cmd output. > > -- Steve SGTM. I will send a v2. Thanks, Jianfeng
|