On Thu, 16 May 2024 15:09:40 -0700 Ian Rogers <irogers@xxxxxxxxxx> wrote: > > This states what the patch does, but omits why. What's wrong with > > asprintf() here? > > Nothing except overhead. I was tracking down an asprintf issue [1], > asprintf breaking the sanitizer stack traces on my debian based linux, > and using asprintf for the sake of copying a character was creating a > huge amount of noise for me. 2 lines-of-code extra means this change > is by one measure more complex but it removes special knowledge of > asprintf return values and the meaning of %c, so on the other hand it > is less complex. I won't be offended if it's not accepted. I don't mind taking the patch, but the above description is needed in the change log, as that explains the purpose of the patch. You don't need to resend, I'll just cut and paste what you wrote above to the commit message. Thanks, -- Steve
|