Re: [PATCH 09/23] perf annotate-data: Maintain variable type info
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 09/23] perf annotate-data: Maintain variable type info
- From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
- Date: Tue, 19 Mar 2024 15:12:28 -0300
- Cc: Ian Rogers <irogers@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-perf-users@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Stephane Eranian <eranian@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, linux-toolchains@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx
- In-reply-to: <CAM9d7cjatKSH7hw_sC3MCmY1fYT+bDBgSpFWJg=RM2oqgL5X0A@mail.gmail.com>
- References: <20240319055115.4063940-1-namhyung@kernel.org> <20240319055115.4063940-10-namhyung@kernel.org> <ZfmcN4YuvQpVgJQN@x1> <CAM9d7cjatKSH7hw_sC3MCmY1fYT+bDBgSpFWJg=RM2oqgL5X0A@mail.gmail.com>
On Tue, Mar 19, 2024 at 10:44:31AM -0700, Namhyung Kim wrote:
> On Tue, Mar 19, 2024 at 7:07 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > > +void exit_type_state(struct type_state *state)
> > > +{
> > > + struct type_state_stack *stack, *tmp;
> > > +
> > > + list_for_each_entry_safe(stack, tmp, &state->stack_vars, list) {
> > > + list_del(&stack->list);
> > list_del_init()?
> Maybe.. but I'm not sure how much value it'd have as we free it right after.
Usually the value is in catching use after free more quickly, i.e.
someone may have a pointer to a freed list and then it would be able to
traverse the list of freed elements.
- Arnaldo
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]