Re: [PATCH 09/14] perf annotate-data: Handle call instructions

[Ian Rogers <irogers@xxxxxxxxxx>]

On Tue, Feb 6, 2024 at 3:17 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> On Fri, Feb 2, 2024 at 7:09 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > On Fri, Feb 2, 2024 at 2:05 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > >
> > > When updating instruction states, the call instruction should play a
> > > role since it can change the register states.  For simplicity, mark some
> > > registers as scratch registers (should be arch-dependent), and
> > > invalidate them all after a function call.
> >
> > nit: Volatile or caller-save would be a more conventional name than scratch.
>
> 'volatile' is a keyword and 'caller_saved' seems somewhat verbose.
> Maybe 'temporary'?

Sgtm, perhaps temp for brevity and the documentation to call them caller save?

Thanks,
Ian

> Thanks,
> Namhyung