On January 26, 2024 4:49:13 PM EST, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: >On Fri, 26 Jan 2024 at 13:36, Linus Torvalds ><torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: >> >> If you have more than 4 billion inodes, something is really really wrong. > >Btw, once again, the vfs layer function you took this from *does* have >some reason to worry. Somebody might be doing 'pipe()' in a loop. > >Also, if your worry is "what if somebody mounts that thing a million >times", the solution to *that* would have been to make it a per-sb >counter, which I think would be cleaner anyway. > I'm more worried about a loop of: cd /sys/kernel/tracing/instances while:; do mkdir foo ; rmdir foo: done Which is what my tests do. And I have run that for over a weekend. >But my real issue is that I think you would be *much* better off just >deleting code, instead of adding new code. > >For example, what purpose does 'e->dentry' and 'ei->d_childen[]' have? >Isn't that entirely a left-over from the bad old days? > I'm not at my computer, but when I tried deleting that, it caused issues with the lookup code. -- Steve >So please try to look at things to *fix* and simplify, not at things >to mess around with and make more complicated. > > Linus
|