From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
The code fix to correctly split start/end/time-window parameters removed
an initialization of "current" which can now fall out being uninitialized
and used for a later compare.
Found with valgrind.
Link: https://lore.kernel.org/linux-trace-devel/20240124122832.4e0b33b7@xxxxxxxxxxxxxxxxxx/
Fixes: 1439b8f518 ("trace-cmd split: Correctly split with start/end/time-window parameters")
Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
---
Changes since v1: https://lore.kernel.org/all/20240124123439.3441eb6f@xxxxxxxxxxxxxxxxxx/
- rebase on the fixed commit, not in the middle of the other split patches
tracecmd/trace-split.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c
index b6c056b5f34b..8c710da15f78 100644
--- a/tracecmd/trace-split.c
+++ b/tracecmd/trace-split.c
@@ -358,7 +358,7 @@ static unsigned long long parse_file(struct tracecmd_input *handle,
enum split_types type,
bool *end_reached)
{
- unsigned long long current;
+ unsigned long long current = 0;
struct tracecmd_output *ohandle;
struct cpu_data *cpu_data;
struct tep_record *record;
--
2.43.0
|