Re: [PATCH 33/34] kernelshark: Allow to reduce a bit more the graph height

Yordan Karadzhov <y.karadz@xxxxxxxxx> · Sun, 21 Jan 2024 21:37:09 +0200

On 1/14/24 19:17, Benjamin ROBIN wrote:

With this configuration, at least one core on the graph can be seen

Please provide a better explanation of the problem you are trying to
solve with this patch. It seems that you decrease the minimum height
of the widget. How is this going to make "at least one core on the
graph can be seen"?

And please make sure you signed all your patches.

Thanks!
Y.


---
  src/KsTraceGraph.cpp | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/KsTraceGraph.cpp b/src/KsTraceGraph.cpp
index bc910c8..4599a12 100644
--- a/src/KsTraceGraph.cpp
+++ b/src/KsTraceGraph.cpp
@@ -593,8 +593,8 @@ void KsTraceGraph::updateGeom()
  	       _layout.contentsMargins().top() +
  	       _layout.contentsMargins().bottom();

  

-	if (hMin > KS_GRAPH_HEIGHT * 8)

-		hMin = KS_GRAPH_HEIGHT * 8;
+	if (hMin > KS_GRAPH_HEIGHT * 6)
+		hMin = KS_GRAPH_HEIGHT * 6;

  

  	setMinimumHeight(hMin);

  




