On Mon, 15 Jan 2024 18:25:46 +0100 Pierre Gondois <pierre.gondois@xxxxxxx> wrote: > > > >> Make use of the previous patches to split all the instances of > >> a trace. > > > > This shouldn't be in the change log. As the change log is for history. > > Think about reading this 5 years from now. Would it make sense about > > "previous patches"? > > I thought it was acceptable to do so as the previous patches would > be just before in the git log, but ok I will write something better. The thing is, what does the previous patches do that's important for this change? If I see this in a change log, I may look at the previous patches, but note that the order is not always the same. I could have imported a patch with a date on it that happens to go between the two and cause the history to be different. But that's usually in merged commits which I avoid here, but still. Sometimes in a change log I'll put: "Now that X was done, we can do Y" Where X is done by previous patches, and if someone is curious, they can go and see X. But just saying "Make use of previous patches" doesn't tell me what those previous patches did. And going back and looking at them, I still don't know exactly how those previous patches are related to this change, except that it did some clean up work. -- Steve
|