Re: [PATCH 13/52] perf annotate-data: Add dso->data_types tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Thu, Dec 21, 2023 at 05:10:53PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Nov 09, 2023 at 03:59:32PM -0800, Namhyung Kim escreveu:
> > +++ b/tools/perf/util/dso.h
> > @@ -154,6 +154,8 @@ struct dso {
> >  	size_t		 symbol_names_len;
> >  	struct rb_root_cached inlined_nodes;
> >  	struct rb_root_cached srclines;
> > +	struct rb_root	data_types;
> > +
> >  	struct {
> >  		u64		addr;
> >  		struct symbol	*symbol;
> 
> At some point we need to make these feature specific members to be
> associated on demand, maybe thru some hash table, etc.
> 
> I.e. the most basic workflow, what everybody needs should be in 'struct
> dso', something one _may_ want, like data profiling, should be in
> associated with that DSO thru some other way.
> 
> I'm applying this now as this is a super cool feature, but think about
> it.

I think I have this series applied up to this patch, the next one is not
applying cleanly, so I'll do the usual set of build tests so that I can
push this for linux-next consumption.

This should be on tmp.perf-tools-next in a few jiffies, in
perf-tools-next a bit later.

- Arnaldo




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux