On Mon, 2 Oct 2023 15:18:26 -0600 Ross Zwisler <zwisler@xxxxxxxxxx> wrote: > > Looks good, you can add: > > Reviewed-by: Ross Zwisler <zwisler@xxxxxxxxxx> > > Actually, I think we need to make similar updates in check_keys() and > check_vals(), else calls to traceeval_init_data_size() will walk off the end > of those respective arrays. Good catch! I'm surprised this didn't crash it my testing. Maybe it as just aligned in a way that there was a NULL after it. -- Steve
|