Re: [PATCH 4/9] libtraceeval: Add traceeval_iterator_remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 24 Aug 2023 14:23:24 -0600
Ross Zwisler <zwisler@xxxxxxxxxx> wrote:

> > > + * Returns 1 if it successfully removed the entry, 0 if for some reason
> > > + * there was no "current entry" (called before traceeval_iterator_next()).
> > > + * or -1 on error.  
> 
> Nit: we never actually return -1.  Only 1 and 0.
> 

Yeah, I usually just throw the -1 in there in case I want to add more
error checking, but since 1 is success, I'll just make it 1 and 0
anyway.

Thanks,

-- Steve




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux