On Tue, 15 Aug 2023 10:55:54 -0600 Ross Zwisler <zwisler@xxxxxxxxxx> wrote: > > --- a/src/histograms.c > > +++ b/src/histograms.c > > @@ -113,7 +113,8 @@ static int compare_traceeval_type(struct traceeval_type *orig, > > * Return 0 if @orig and @copy are the same, 1 if @orig is greater than @copy, > > * -1 for the other way around, and -2 on error. > > */ > > -static int compare_traceeval_data(union traceeval_data *orig, > > +static int compare_traceeval_data(struct traceeval *teval, > > + union traceeval_data *orig, > > const union traceeval_data *copy, > > struct traceeval_type *type) > > Nit: it would be nice if these had the same ordering as the args to > traceeval_data_cmp_fn. > Yeah, I noticed that to, but figured I can change it later, as it's not API. I'll update it. > Other than that you can add: > > Reviewed-by: Ross Zwisler <zwisler@xxxxxxxxxx> Thanks Ross, -- Steve
|