From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
If no copy() function exists for a type but a release() function does,
then do the release on the old copy.
Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
---
src/histograms.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/histograms.c b/src/histograms.c
index f7f72dd3a50b..8c73d8cd9f45 100644
--- a/src/histograms.c
+++ b/src/histograms.c
@@ -596,12 +596,16 @@ static int copy_traceeval_data(struct traceeval_type *type,
/*
* Free @data with respect to @size and @type.
*
- * Does not call release on type TRACEEVAL_TYPE_DYNAMIC.
+ * Does not call release() if a copy() exists.
*/
static void data_release(size_t size, union traceeval_data **data,
struct traceeval_type *type)
{
for (size_t i = 0; i < size; i++) {
+ /* A copy should handle releases */
+ if (type[i].release && !type[i].copy)
+ type[i].release(&type[i], &(*data)[i]);
+
if (type[i].type == TRACEEVAL_TYPE_STRING)
free((*data)[i].string);
}
--
2.40.1
|