Re: [PATCH 5/6] libtraceeval histogram: Fix the return value of traceeval_query()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 10 Aug 2023 11:47:50 -0600
Ross Zwisler <zwisler@xxxxxxxxxx> wrote:

> On Tue, Aug 08, 2023 at 11:13:12PM -0400, Steven Rostedt wrote:
> > From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
> > 
> > The comments state that traceeval_query() returns 1 if found, 0 if not,
> > and -1 on error, but in reality it returns 0 if found and 1 if not found.  
> 
> The comment currently says:
> 
> > /*
> >  * Find the entry that @keys corresponds to within @teval.
> >  *
> >  * Returns 0 on success, 1 if no match found, -1 on error.
> >  */  
> 
> I think this needs to be updated to match the new logic (1=found, 0=not
> found, -1=error)
> 

Yeah, but I believe Stevie's latest version fixed all this.

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux