On Wed, 2 Aug 2023 15:54:03 -0600 Ross Zwisler <zwisler@xxxxxxxxxx> wrote: > > +/** > > + * Deallocate all possible data stored within the entry. > > + */ > > +static void clean_entry(struct entry *entry, struct traceeval *teval) > > +{ > > + if (!entry) > > Should we check for NULL 'teval' as well? No, because teval can't be NULL here. As to get here, we need to go through traceeval_release() which does the check for !teval. -- Steve > > > + return; > > + > > + // deallocate dynamic traceeval_data > > + clean_data(entry->keys, teval->def_keys); > > + clean_data(entry->vals, teval->def_vals); > > + free(entry->keys); > > + free(entry->vals); > > +}