Re: [RFC PATCH v3 4/6] sched, tracing: reorganize fields of switch event struct
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC PATCH v3 4/6] sched, tracing: reorganize fields of switch event struct
- From: Ze Gao <zegao2021@xxxxxxxxx>
- Date: Tue, 1 Aug 2023 21:16:49 +0800
- Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Ian Rogers <irogers@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, Ze Gao <zegao@xxxxxxxxxxx>
- In-reply-to: <20230801114650.GE79828@hirez.programming.kicks-ass.net>
- References: <20230801090124.8050-1-zegao@tencent.com> <20230801090124.8050-5-zegao@tencent.com> <20230801114650.GE79828@hirez.programming.kicks-ass.net>
Oops, I thought sending this series for RFC is the "effort" you mean
to audit the users :/
Correct me if I'm making stupid moves here and enlighten me what
I should do furthermore to audit the users.
Thanks,
Ze
On Tue, Aug 1, 2023 at 7:47 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Tue, Aug 01, 2023 at 05:01:22PM +0800, Ze Gao wrote:
> > Report priorities in 'short' and prev_state in 'int' to save
> > some buffer space. And also reorder the fields so that we take
> > struct alignment into consideration to make the record compact.
> >
> > Suggested-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
>
> I don't see a single line describing the effort you've done to audit
> consumers of this tracepoint.
>
> *IF* you're wanting to break this tracepoint ABI, because seriously
> that's what it is, then you get to invest the time and effort to audit
> the users.
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]