Re: [PATCH v3] trace-cmd: Check all strdup() return values

[Steven Rostedt <rostedt@xxxxxxxxxxx>]

On Sat, 3 Jun 2023 13:20:37 +0200
Markus Elfring <Markus.Elfring@xxxxxx> wrote:


> …
> > +++ b/lib/trace-cmd/trace-output.c
> > @@ -230,6 +230,7 @@ void tracecmd_set_out_clock(struct tracecmd_output *handle, const char *clock)
> >  	if (handle && clock) {
> >  		free(handle->trace_clock);
> >  		handle->trace_clock = strdup(clock);
> > +		/* TODO: report error if failed to allocate */
> >  	}
> >  }  
> 
> How will this place be improved?

Bah. This patch is not worth the pain. I'm just going to drop it.

-- Steve