Re: [PATCH] trace-cmd record: Remove redundant check of instance in allocate_instance()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2 Jun 2023 15:12:11 +0200
Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> > The error path only happens after the instance has been allocated.
> > No need to check if it exists again.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=217127  
> 
> Will it be more appropriate to refer to an other bug report here?

I first wasn't going to bother with it, but then I started modifying
code around it where you mention this in the above mentioned bug, and
tagged that one. I can modify it to have you original one (I'll do that
internally, not with a v2).

> 
> 2023-03-04
> Improve exception handling in allocate_instance()
> https://bugzilla.kernel.org/show_bug.cgi?id=217128
> 
> 
> Will any additional adjustments become helpful for jump targets
> in this function implementation?

No need to spend cycles on this. It's a very slow path. Optimizing it
is nothing more than an academic exercise.

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux