Re: [PATCH] libtracefs: Fix the label usage in tracefs_instance_set_affinity()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 12 Mar 2023 21:32:23 +0100
Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> Date: Sun, 12 Mar 2023 21:24:34 +0100
> 
> The label “out” was used to jump to a source code place after some
> failure cases. This implementation detail hindered better exception handling.
> 
> Use more appropriate labels instead.
> 
> * Reorder jump targets at the end.
> 
> * Omit an extra initialisation (for the variable “set”)
>   which became unnecessary with this refactoring.
> 
> 
> Fixes: 987d8c1a62dadff45e6006c4ce5f3bd138842567 ("libtracefs: Add tracefs_instance_set_affinity() APIs")
> Signed-off-by: Markus Elfring <Markus.Elfring@xxxxxx>

Please, stop these patches. I do not feel this type of patch is important
enough for the churn.

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux