On 2/1/23 20:23, Steven Rostedt wrote: > On Tue, 31 Jan 2023 17:30:02 +0100 > Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote: > >> Add some helper functions to read and set the on/off osnoise/options. >> No usage in this patch. >> >> In preparation for hwnoise tool. > > Honestly, I don't see why patches 1-5 isn't a single patch. It's not that > big of a change, and everything in 1-5 is to do what 5 does. Breaking it up > this fine grain isn't helpful in reviewing, as I found that I had to apply > 1-5 and then do a diff from where I started to make sense of any of it. Maybe what is missing is a clear: In preparation for hwnoise tool. IMHO, it is easier to understand by using small "logical" pieces in preparation for the "conclusion." But I see your point, and it does not hurt :-). I will reduce the number of patches. -- Daniel > > -- Steve > > >> >> Signed-off-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> >> Cc: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> >> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> >> Cc: Jonathan Corbet <corbet@xxxxxxx> >> --- >>
|