On Wed, 2022-06-08 at 13:05 -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
>
> Add a test to make sure that splice works on the source directory before
> using it, and if not automatically switch over to read/write method.
>
> Suggested-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213659
> Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> ---
> Johannes, can you test this?
> I want to make sure that it fixes the issue.
>
Umm, yeah, long time ago. Sorry, I've been meaning to do that, but it
isn't easy, so I kept pushing it off.
My use case for this was UML with hostfs, which I've since fixed (kernel
upstream commit 1568cb0e6d97 ("hostfs: support splice_write"); I can
revert that easily of course, but then I still have to build my own
trace-cmd with that patch... But that needs libtracefs 1.6 which even
Fedora doesn't ship.
Given that you've merged the patch already, I think I'll just give up on
testing it, sorry about that.
johannes
|