On Sat, 14 Jan 2023 00:51:05 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > Hi Paulo, > > A couple of nits about submitting a follow up patch. > > 1) A second patch should always start a new thread. It's easier to find > in inboxes. > > If you want, you could add a link to the first thread in the "changes" > section (see below). And I forgot to update that "see below" comment. [..] > > Open code the libc's execvp routine into trace-cmd so ftrace will only > > start recording once the command is found when it needs to be found in > > PATH. > > > > Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@xxxxxxxxx> > > --- > > Changelog: > > > > - v2: open code execvp routine into trace-cmd. (Req. Steve Rostedt) > > - v1: https://lore.kernel.org/linux-trace-devel/Y7dUo6woh9Y31cdl@xxxxxxxxxxxxxxx/ Because you did what I was going to say and I did not update the previous statement ;-) -- Steve
|