On Sat, 24 Dec 2022 11:36:50 +0100 Daniel Wagner <dwagner@xxxxxxx> wrote: > On Fri, Dec 23, 2022 at 12:08:51PM -0500, Steven Rostedt wrote: > > On Fri, 23 Dec 2022 08:32:43 +0100 > > Daniel Wagner <dwagner@xxxxxxx> wrote: > > > > > > And since this holds libtracecmd, does it really need a dependency? > > > > > > IIRC, I saw that the CFLAGS from libtraceevent are used for the > > > trace-cmd, but I might just miss something. If trace-cmd doesn't use > > > libtraceevent or libtracefs directly than it should be possible to drop > > > these direct dependencies. > > > > No, I believe that trace-cmd still uses libtracefs and libtraceevent > > directly. > > I did try to build without listing the direct dependency, the build > failed because the compiler didn't find the libraries header files. I > think we need to leave them. Though with the current approach to trigger > the static libtraceevent directly from trace-cmd we need it those anyway. Just to clarify, I wasn't talking about the libtracefs/event libraries. I was talking about the libtracecmd library that was listed as a dependency. Why do we need to check the version of that, as we are going to be using the one in the repo regardless? Also, how do you install the libraries? When I do a ninja -C build install it only installs the trace-cmd executable. -- Steve
|