Re: [PATCH v1 1/2] perf build: Require libtraceevent from the system
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 1/2] perf build: Require libtraceevent from the system
- From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
- Date: Fri, 18 Nov 2022 12:02:38 -0300
- Cc: Ian Rogers <irogers@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, Steven Rostedt <rostedt@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Linux Trace Devel <linux-trace-devel@xxxxxxxxxxxxxxx>, Stephane Eranian <eranian@xxxxxxxxxx>
- In-reply-to: <Y3dQxVNwGmQMWPP0@hirez.programming.kicks-ass.net>
- References: <20221117224952.358639-1-irogers@google.com> <20221117224952.358639-2-irogers@google.com> <Y3dQxVNwGmQMWPP0@hirez.programming.kicks-ass.net>
Em Fri, Nov 18, 2022 at 10:30:45AM +0100, Peter Zijlstra escreveu:
> On Thu, Nov 17, 2022 at 02:49:51PM -0800, Ian Rogers wrote:
> > Unconditionally require libtraceevent to come from the system. Force
> > the determination of the libtracefs version if it is present.
>
> -ENOMOTIVATION
Yeah, I was going to ask for that as well :-\
And the motivation was spelled out in the discussion that led to this
patch:
https://lore.kernel.org/lkml/CAP-5=fWxAjEia-Qbm0RVzKOxyiod8rUOBieqaGK=DtQboDe3Qw@xxxxxxxxxxxxxx
> also:
>
> Makefile.config:1196: *** Error: libtraceevent is missing, please install libtraceevent-dev. Stop.
yeah, this probably should work like with other libraries, don't stop
the build, just don't build features that depend on libtraceevent,
warning the user that features foo, bar and baz won't be available.
For people working with just hardware, software, cache events, no
problem.
- Arnaldo
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]