Re: [PATCH] rtla: Fix exit status when returning from calls to usage()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] rtla: Fix exit status when returning from calls to usage()
- From: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
- Date: Fri, 4 Nov 2022 15:41:53 +0100
- Cc: linux-trace-devel@xxxxxxxxxxxxxxx, lkml <linux-kernel@xxxxxxxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, Chang Yin <cyin@xxxxxxxxxx>
- In-reply-to: <20221103135742.9523-1-jkacur@redhat.com>
- References: <20221103135742.9523-1-jkacur@redhat.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0
On 11/3/22 14:57, John Kacur wrote:
> rtla_usage(), osnoise_usage() and timerlat_usage() all exit with an
> error status
missing .
> However when these are called from help, they should exit with a
> non-error status.
>
> Fix this by passing the exit status to the functions
missing .
> Note, although we remove the subsequent call to exit after calling
> usage, we leave it in at the end of a function to supress the compiler
suppress?
> warning "control reaches end of a non-void function"
missing .
Yep, that is a problem, and agree with the solution (I am already doing it
in the rv cmd line).
-- Daniel
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]