[PATCH] Initialize field_size prior to use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Building with CC=clang yields:

```
  COMPILE FPIC       event-parse.o
event-parse.c:4313:17: warning: variable 'field_size' is uninitialized when used here [-Wuninitialized]
                                           offset, field_size)) {
                                                   ^~~~~~~~~~
event-parse.c:4108:25: note: initialize the variable 'field_size' to silence this warning
        unsigned int field_size;
                               ^
                                = 0
1 warning generated.
```

dynamic_offset_field will compute the length of the field and so use
that to give field_size a legitimate value.

Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
 src/event-parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/event-parse.c b/src/event-parse.c
index 980e980..b3e0ea7 100644
--- a/src/event-parse.c
+++ b/src/event-parse.c
@@ -4308,7 +4308,7 @@ eval_num_arg(void *data, int size, struct tep_event *event, struct tep_print_arg
 	case TEP_PRINT_DYNAMIC_ARRAY:
 		/* Without [], we pass the address to the dynamic data */
 		dynamic_offset_field(tep, arg->dynarray.field, data, size,
-				     &offset, NULL);
+				     &offset, &field_size);
 		if (check_data_offset_size(event, arg->field.name, size,
 					   offset, field_size)) {
 			val = (unsigned long)data;
-- 
2.38.0.rc1.362.ged0d419d3c-goog




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux