Re: [PATCH V9 01/16] rv: Add Runtime Verification (RV) interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 31 Jul 2022 19:49:23 +0200
Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:

> On 7/31/22 19:01, Steven Rostedt wrote:
> > static int da_monitor_init_##name(void)                                                         \
> > {                                                                                               \
> >         int slot;                                                                               \
> >                                                                                                 \
> >         slot = rv_get_task_monitor_slot();  <- if this returns positive, things break           \
> >         if (slot < 0 || slot >= RV_PER_TASK_MONITOR_INIT)                                       \
> > 
> > And we probably need slot to be negative if it is greater or equal to RV_PER_TASK_MONITOR_INIT.
> > 
> >                 return slot;                                                                    \
> >                                   
> 
> ok, there will be a problem when RV_PER_TASK_MONITOR_INIT changes to > 1. This will need to be patched to
> return negative. So far we have only one because there is only one per task monitor.
> 

Exactly. And reviewers like Tao and myself are going to continue to
flag it as a bug as we don't assume that RV_PER_TASK_MONITOR_INIT will
stay 1 ;-)

-- Steve




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux