Re: [Linux v5.19-rc2] rtla: Errors when running `make tools/clean`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 30, 2022 at 11:57 AM Daniel Bristot de Oliveira
<bristot@xxxxxxxxxx> wrote:
>
> Hi Sedat,
>
> On 6/27/22 08:23, Sedat Dilek wrote:
> > On Wed, Jun 15, 2022 at 12:23 AM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> >> [ CC linux-kbuild folks ]
> >>
> >> Hi,
> >>
> >> while digging into a perf issue I see this:
> >>
> >> $ cd /path/to/linux.git
> >>
> >> $ LC_ALL=C make -C tools/ clean 2>&1 | tee ../make-log_tools-clean.txt
> >> ...
>
> Do you mind trying this?
>
> diff --git a/tools/tracing/rtla/Makefile b/tools/tracing/rtla/Makefile
> index 3822f4ea5f49..1bea2d16d4c1 100644
> --- a/tools/tracing/rtla/Makefile
> +++ b/tools/tracing/rtla/Makefile
> @@ -1,6 +1,6 @@
>  NAME   :=      rtla
>  # Follow the kernel version
> -VERSION :=     $(shell cat VERSION 2> /dev/null || make -sC ../../.. kernelversion)
> +VERSION :=     $(shell cat VERSION 2> /dev/null || make -sC ../../.. kernelversion | grep -v make)
>
>  # From libtracefs:
>  # Makefiles suck: This macro sets a default value of $(2) for the

Thanks for the diff Daniel.

Indeed, it fixes the build-error for me.

$ cd /path/to/linux.git

$ git status -s
M tools/tracing/rtla/Makefile

$ LANG=C LC_ALL=C make -C tools/ clean 2>&1 | tee ../make-log_tools-clean.txt
[ ... ]
 DESCEND rtla
make[2]: Entering directory '/home/dileks/src/linux/git/tools/tracing/rtla'
make -C /home/dileks/src/linux/git/tools/tracing/rtla/../../../Documentation/tools/rtla/
clean
make[3]: Entering directory
'/home/dileks/src/linux/git/Documentation/tools/rtla'
rm -f rtla-osnoise-hist.1 rtla-osnoise-top.1 rtla-osnoise.1
rtla-timerlat-hist.1 rtla-timerlat-top.1 rtla-timerlat.1 rtla.1
make[3]: Leaving directory '/home/dileks/src/linux/git/Documentation/tools/rtla'
make[2]: Leaving directory '/home/dileks/src/linux/git/tools/tracing/rtla'
make[1]: Leaving directory '/home/dileks/src/linux/git/tools/tracing'

Please feel free to add my...

Reported-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>

...when you have prepared a real fix.

-sed@-



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux