From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
If the initialization of tracecmd_init_data() fails, the processing will
continue and this can cause errors latter on that are unrelated to the
actual problem. Fail immediately instead.
Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
---
lib/trace-cmd/trace-input.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index 11c0057589b6..c181c7d93be4 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -5382,12 +5382,14 @@ static int copy_trace_data_from_v6(struct tracecmd_input *in_handle,
static int copy_trace_data_from_v7(struct tracecmd_input *in_handle,
struct tracecmd_output *out_handle)
{
- int ret = 0;
+ int ret;
int i;
/* Force using temporary files for trace data decompression */
in_handle->read_zpage = false;
- tracecmd_init_data(in_handle);
+ ret = tracecmd_init_data(in_handle);
+ if (ret < 0)
+ return ret;
tracecmd_set_out_clock(out_handle, in_handle->trace_clock);
/* copy top buffer */
--
2.35.1
|